[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] page-alloc: further adjust assign_page{,s}()

To: Jan Beulich <jbeulich@xxxxxxxx>
From: Ian Jackson <iwj@xxxxxxxxxxxxxx>
Date: Mon, 20 Sep 2021 11:25:34 +0100
Cc: "xen-devel\@lists.xenproject.org" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
Delivery-date: Mon, 20 Sep 2021 10:25:40 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Jan Beulich writes ("[PATCH] page-alloc: further adjust assign_page{,s}()"):
> The on-commit editing of 5260e8fb93f0 ("xen: re-define assign_pages and
> introduce a new function assign_page") didn't go quite far enough: A
> local variable and a function argument also would have wanted adjusting.

This kind of thing is why I really dislike our practice of on-commit
editing.

Ian.

References:
- [PATCH] page-alloc: further adjust assign_page{,s}()
  - From: Jan Beulich

Prev by Date: Re: [PATCH 1/6] xen/trace: Don't over-read trace objects
Next by Date: Re: [PATCH 3/6] tools/console: use xenforeigmemory to map console ring
Previous by thread: Re: [PATCH] page-alloc: further adjust assign_page{,s}()
Next by thread: [PATCH v2 0/4] swiotlb-xen: remaining fixes and adjustments
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.