[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 10/10] xsm: remove alternate xsm hook interface
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 17 Sep 2021 14:13:40 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8F/k79EhMHT3GBRKH4JctgK/8Uqk+wst81sqDUTHM9I=; b=a32RJeqHP3F/ItJ+wd796j+ORuUXLOVUVkEqiy92/5l4Mji2fOezKwskcOp8dlpnqODBF2TheR7mSmxTUAefaAmUtGHPQre+lfkdYxPB7thSWnr6r/otaleJ1mqLymtyqw++ZytyDhsEBjEev3Oij7Bg9DK/ThJKuIaZnW38mFsfSB/cX4qsmz2Foqa51GeYEbM+eEuUD5XiXEz8Ez2YiV88qh8Sawei8lw4sjku5Es/3W1O+LoP2nRploldDE6+3uR6BSwer3nMwF4f4LVbCnjrnkItstQywuAAp1wPLFVP424gXg/CDtkfMS8pY6tLlANVJyQAxVru+zVXaa367w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BJnBINjIc//vEDQnFihqQY/8i9/C0wr6xH6W44N8kFmXc8aRUZ+MqU1tbSpy3U9SGo2MjhMgknEmxSWz/sJnnoHCkJySyWk6NRpKZPqjjsQUShBEQGTm6o5ie0l7j0QpxLtST9A0DnxhE/GSZ3RI0EBKS3k0fbxsPkqHO4lSuSlyn4DYowV3FTHLpVrPpQMz6MdB9+923F72hOi7Kvo3CxYHmqc55dCezpwPkM82zxr5piUwWQhKE4HHBWrVyxPLvz7eAZA5EaRQht/qBh4CDjgC0guTiqbmjmYBsBP1v3G16w5pDnq1gt+HOC2s1guAulqLwaSgfNnPeowE6LaiRA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 17 Sep 2021 12:13:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.09.2021 22:13, Daniel P. Smith wrote:
> Hidden behind macro magic is an alternative xsm hook interface dedicated for
> use when the dummy/default policy is the only one built. This alternative
> interface increases code complexity and code size in the core security
> framework of Xen.
What does "code size" refer to here? I would have expected the binaries to
be smaller with inline functions in use. And ...
> ---
> xen/include/xsm/xsm-core.h | 51 ++-
> xen/include/xsm/xsm.h | 275 ++++++++++------
> xen/xsm/Makefile | 2 +-
> xen/xsm/dummy.c | 2 +-
> xen/xsm/dummy.h | 659 +++++++++++++++++++++++++++++++++++++
> xen/xsm/silo.c | 2 +-
> xen/xsm/xsm_core.c | 4 -
> 7 files changed, 868 insertions(+), 127 deletions(-)
> create mode 100644 xen/xsm/dummy.h
... the statistics here suggest an increase in source code size.
Jan
|
