[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo
- To: Oleksandr <olekstysh@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 16 Sep 2021 17:47:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+ODLk6buZ5bRYNHDO5mkilEfQa+D2sDqx44UesSdg94=; b=nn/6/qAEQ271143Xq51MqZRxtT9Py2SZtSJipc216OjnMop26oo2+9XNlKXLA/nFqzK0Py3Tq2UPKJ9OhVUCSUrYHcmXU7x9sQU8vA3Zn6HZdaNVUCxkV1xzUxWmn2l+1UolxjeNF4HXpjATW3lcrnNYPZ1Rzu3DgKJLQrsq7Bv85N/Gn5T1ltVjuiD8MLco3kts94GfDu1yNmETp8q10y6b7kIwqQcfsf92qqqwFEa7FvRCYReB+8ZCte841wFNvI/C4D5wLdaQGTkdrkIGVWNXfjka8FuJg5YnulH9g+l5jwi7YpEk4OukgNw/fyKPYwRk98EjHOXp2q2AwpK0Xg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IhBdAfDgxlYeQczniHLpSAKw1o9LTK5KPZTgl7r3Nfy8CGv/w6qCrdGvS0WOtP4ufnhbFoBkuVYRTL8yo3uzOH1OGBYHzYrxxeg7UeIzfURm3hOP5ZUm35SFFGD3trPqJtQ82RWaMWqTPvetS63Z02WzLzejPhYH+WkTnMhXhndNl5fSE03/kmwQlgvfB8YwwrEUSDFKB3PAVuEV9EE8b52fWCL0rKmBicHyJ1bhN1BIqfR/LaIgrJC5vGh+wpkFLCFwinnPolKVgq2UHiqmaBWJRdsuGy5NQTtl5SQWPLbWzLgdJedJbHaOrrBpg7gQaf4jRdIs1kwDP1WWmXW1lg==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 16 Sep 2021 15:47:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.09.2021 17:43, Oleksandr wrote:
> On 16.09.21 17:49, Jan Beulich wrote:
>> On 10.09.2021 20:18, Oleksandr Tyshchenko wrote:
>>> @@ -120,6 +120,7 @@ struct xen_sysctl_physinfo {
>>> uint64_aligned_t outstanding_pages;
>>> uint64_aligned_t max_mfn; /* Largest possible MFN on this host */
>>> uint32_t hw_cap[8];
>>> + uint32_t gpaddr_bits;
>>> };
>> Please make trailing padding explicit. I wonder whether this needs
>> to be a 32-bit field: I expect we would need a full new ABI by the
>> time we might reach 256 address bits. Otoh e.g. threads_per_core is
>> pretty certainly oversized as well ...
>
> I take it, this is a suggestion to make the field uint8_t and add
> uint8_t pad[7] after?
I view this as a viable option at least.
Jan
|
