[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tools/xl: fix autoballoon regex
- To: Dmitry Isaikin <isaikin-dmitry@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 16 Sep 2021 12:28:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NMwn1Kd0VYtqHe8kwd7LAUWfk8cZ+xmjC6aX3kutlhw=; b=n+fg5mkvQb8ZVWS3xULOFK5DqTBFavMuEHZw+kk0NmdB/9pkBhS6uJ3t2vLdjyre0rs+Wj9czHngLeBYRG+XmeYPbW8cZUSnv7sqKe+cOU+ZoRh9OgSR5N1nlpieaH/xgXmsC5Z+wk41rBTDDj6V90uN1Z2DlhQEpokrVrZnX1OugDik8S+wJXh2LAGCGy0d73qbxUpQ9YpBIr4msQ7hoyoS+v+MuKQNg/vGcsvFlUwZdpv4qcWJzUpkTGmP471JhqfA8VmoaWAsyxUDRamqg9IBFvYO8hmpRVeVLudVBaa8TEIdi1NtARkG/w5JbUBC1d18+E3Iu4xYRabFPid/9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fg6qtAHj6KOqCUBcnKQMOjQPFHbv3PdPqWv1ha6naX8A0R9WR+/JKodOBI3JS2lVvPqHDObNYoFlJJQXv8IOMFYs5ANYaKHwl8iKvAvH0MePZocHBlBAwqH3IHZzkNyqDSSMod/YJ5kYUmMCBOebJ90obqF8h/4gMcwpng/RDf2fU9A2Xlri3FoF8/IfuU7Ztwc0WgeFX0TzCgx3FrvQHOEqH1uMGnbMMX2YhcxfegZDpWOY0saKly19utMXCYu4piCcvHBIDgrMSFlu9sjZjPbmvKIyGmocbR02STSm4PFz2aZk3chznR4OggYQF0TbHAZ1hCMB+X6oxHgv1DcGeg==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 16 Sep 2021 10:28:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.09.2021 11:34, Dmitry Isaikin wrote:
> --- a/tools/xl/xl.c
> +++ b/tools/xl/xl.c
> @@ -81,7 +81,7 @@ static int auto_autoballoon(void)
> return 1; /* default to on */
>
> ret = regcomp(®ex,
> - "(^| )dom0_mem=((|min:|max:)[0-9]+[bBkKmMgG]?,?)+($| )",
> + "(^| )dom0_mem=((|min:|max:)-?[0-9]+[bBkKmMgG]?,?)+($| )",
Wouldn't this be a good opportunity to also add [tT] to the list
of permitted granularity suffixes? The hypervisor's
parse_size_and_unit() has been supporting this for quite some
time ...
Jan
|
