[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/11] xen/arm: Setup MMIO range trap handlers for hardware domain
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Tue, 14 Sep 2021 14:24:10 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FZ8QhArfeYPBGE9lk/pv9xQcsubY+TFE+qbmLG6HSek=; b=CpiHIatoFmxR3k+0D6DSJHj521RjvncNlB6mzGQ0qFkOxkm0AeynWRhlju1il3HVfTyuHgGIuqKXYEvqwzV17TEwuuks5Zqw9YeFerREUFm0hdLMRUk00hjVIIUMEMzPMMvXn6/Q7bHJjyPGntAGHAzaKlv1p1riaBoV6CZCKSMJmBAgFAnvsh5hhJVeelfBwRWL9+SCOy2tFd42Mbv8IdWbnbBGJw9il2orPMJRaOG/BnAl2+nYXxAKZRKfg9TGHXB23K6FZ+HHFTVBIO8cXwmALw2/ZSkl/KhZZ/h8RJn+agholICk+DAZxhxiS8V2dUILHSNk5fctwi+VVnj38g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vd5jllhtNaGZPhYrqBKLXsTRdsj3StCRczJeXlsurJUYNp9NXtMId6KcpMZH9DHuVhv0/n46ExxKDVVaJW1S0+H5TGcgXbDg6rPJ7VNhw6acXIJFuEa1VK62CxXY5aLeFYE+d7NGyRmYbWcjOTTw9GRWEqTTa/ffEtCm24dYfZsmSzlFlNgFVn54XFnQeZFtKM5d/1Pv9NC8UmdVw5Dxbf++A8Klv4M5Jdi8EcVJz+V/IN7zviwZyGYH++4FEm4C8HSx5L7G8MHjVzRIiR/ei4mwiC6yJZ3+S9SVqJIbZdAAHrnmzaPunHFAJwS75lO1q/tybIbeW44dRuG7VxkMog==
- Authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- Delivery-date: Tue, 14 Sep 2021 14:24:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXoJ6eIuPEzuAZLUmx1GA90MGEBKudvyQAgAXn/AA=
- Thread-topic: [PATCH 09/11] xen/arm: Setup MMIO range trap handlers for hardware domain
}
>>
>> +static int pci_ecam_register_mmio_handler(struct domain *d,
>> + struct pci_host_bridge *bridge,
>> + const struct mmio_handler_ops
>> *ops)
>> +{
>> + struct pci_config_window *cfg = bridge->sysdata;
>> +
>> + register_mmio_handler(d, ops, cfg->phys_addr, cfg->size, NULL);
>> + return 0;
>> +}
> Given that struct pci_config_window is generic (it is not specific to
> one bridge), I wonder if we even need the .register_mmio_handler
> callback here.
>
> In fact, pci_host_bridge->sysdata doesn't even need to be a void*, it
> could be a struct pci_config_window*, right?
Rahul, this actually may change your series.
Do you think we can do that?
>
> We could simply call:
>
> register_mmio_handler(d, ops, cfg->phys_addr, cfg->size, NULL);
>
> for each bridge directly from domain_vpci_init ?
If Rahul changes the API then we can probably do that.
|
