[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v5 05/10] xsm: apply coding style
On 9/10/21 2:15 AM, Jan Beulich wrote: On 10.09.2021 04:12, Daniel P. Smith wrote:@@ -70,7 +73,7 @@ void __xsm_action_mismatch_detected(void); #endif /* CONFIG_XSM */static always_inline int xsm_default_action(- xsm_default_t action, struct domain *src, struct domain *target) + xsm_default_t action, struct domain *src, struct domain *target)Here and below you're now introducing hard tabs. In Xen style we don't ever use hard tabs for indentation; this is limited to files inherited from elsewhere. It's also not clear why you've touched this instance at all: The 4 chars indentation was correct already, as previously pointed out by Andrew (on perhaps a different example). Jan I honestly don't know what is going on. Since right now my primary focus is on Xen, I have my vimrc set to 4 space tabs with expand tabs and I am not manually changing. I will retab the file in the next submission. v/r, dps
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |