[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 2/2] build: add --full to version.sh to guess $(XEN_FULLVERSION)
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 9 Sep 2021 13:43:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HF0S0KYJ4nB0qOMnXGPL8jt8y++5z9GqqRNKB6MARN0=; b=m231F7oqGHiCrc8r1s6Eq3ap/3YW/n+jHc98Z4eyHI8UUfWvHUPzKnIejqGQR4z7xcGgZZ8z+4TsRCEw9vk1GYXiiV3BfllEKMhnaNsTNyy/jAnMVanLCwym91fI0oJhvE/PiA0yvDGQlWhAEeVRRgASVwy/E3Wnt95782nub00dn55RGARMGAc4KObzd51PyTwauDrW5fC0NoYmcv9IwwIZ6DRv7TTo+mmKS2a1OiwEAa9U4RJdGxnppPeM5c/sDeQBEcWRUd/Y9HRR7K2Mvyfhccmt5wxkRlIfm8bD6co+11LtryXs231wyIzLekfZgdAQ+gfGPQM96ILTTy+fsw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VIy+oDLGnRjpgsKvqpolAjYIr+V5PQOcRojrv8z/qmfm1viYMd3yJp0ImtJNh851qP86v455b3ekouopqidl2/JemaFr5WhjsHBFpgFgh7AuyQb7fZJe/VA3KfWezDDgbscCvtZxPNY2OKYfQ7gNxdC5PboSjGzuM1Ez2PWI2SPaVQWDAahFzPyIBAvCCpivl2k0VW8mHMhCJGFIzdzXqltqZmlJwJChrPfU5Rl1KZ5QLaiqSFAY+I+6qVv8A0izRgihD5Bxvlxhx/aL/NfxQINBw9Es3b1U3gpjsKpWdELMOnfqj+NMYA1hy46K+6ExIpICQ5U5qHgJCjh9tWt+9g==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 09 Sep 2021 11:43:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.09.2021 13:10, Anthony PERARD wrote:
> :-( I think I just found a package overriding XEN_VENDORVERSION with a
> command line argument, the AUR package. So ./version.sh needs help from
> the build system:
>
> Maybe
>
> XEN_FULLVERSION=$(shell env XEN_EXTRAVERSION=$(XEN_EXTRAVERSION)
> XEN_VENDORVERSION=$(XEN_VENDORVERSION) $(SHELL) $(XEN_ROOT)/version.sh --full
> $(XEN_ROOT)/xen/Makefile)
>
> or probably just exporting those two var in Config.mk or tools/Rules.mk.
Either sounds okay to me, fwiw.
Jan
|