[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN RFC PATCH 26/40] xen/arm: Add boot and secondary CPU to NUMA system
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 26 Aug 2021 14:26:08 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YUMf2oJZu4O7aqddxSDdsmynusLi89OLN4iA7Qnlc+8=; b=SWm3DzYHJpExACavziPxdBrEu7O9a6d914d1bXngNeSrMEpGxFKhFhZTk/JBHDCahrLxLBxTX4zvOpBjn/QPY1Aea/HwJZwf3GKgx2JBglwI54brzyBAXOMTyka6tPSqB5seJf9T8P6TxOxy/8PLZF45OqmP2+owwITcOAQsOvJ0h3gt9vNCphY6R5htrEB45hw/KeE/ePFbHHi3b86CGCeKOayBiL77FfdFF7kaoNjCZGxM8lgmXwFm4rmasFLb391kg86gcKZfJLD320WTvoMyx+1DQ/anzqd5/yZ8++3LfQeMem2GwIxvGpJ1vQln3LC7tWpxmsLvaq2nbU99Cw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eSDH82o8p6F7H7tC53Gz6jgAoLr0qryyPkqRggPLLRgLBtwbLNzFmqIzH2O3JBjypApwMHE8hf/3NJ5wm8c9Ndk61fo4p+rE9JURU26fNYzxAKyDCD7Pl9fxvicsR8DVYFjEMVJwcQYgcFHAce17jLcpHw+r4EmXhpfTf7xqrMTTOK44QShES/HWhkd+uY0KK80+7Jb0MkdMRWtORjp6WpxTmnJVPU2FMquNpBR4whHzTc6V/quf3dkVOsXnOtrup1O5H4Cn30KTANXSRB82uXG/Yuh+i2AbwcruXtsTu8scm5vm2vfpOcoqbX3ahCYo0eoQNfUbss+pkLOuMCXi2A==
- Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Thu, 26 Aug 2021 12:26:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.08.2021 14:08, Wei Chen wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2021年8月26日 17:40
>>
>> On 26.08.2021 10:49, Julien Grall wrote:
>>> Right, but again, why do you want to solve the problem on Arm and not
>>> x86? After all, NUMA is not architecture specific (in fact you move most
>>> of the code in common).
>>>
>
> I am not very familiar with x86, so when I was composing this patch series,
> I always thought that if I could solve it inside Arm Arch, I would solve it
> inside Arm Arch. That seems a bit conservative, and inappropriate on solving
> this problem.
>
>>> In fact, the risk, is someone may read arch/x86 and doesn't realize the
>>> CPU is not in the node until late on Arm.
>>>
>>> So I think we should call numa_add_cpu() around the same place on all
>>> the architectures.
>>
>> FWIW: +1
>
> I agree. As Jan in this discussion. How about following current x86's
> numa_add_cpu behaviors in __start_xen, but add some code to revert
> numa_add_cpu when cpu_up failed (both Arm and x86)?
Sure - if we don't clean up properly on x86 on a failure path, I'm all
for having that fixed.
Jan
|
