[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH v7 10/51] build,arm: move LDFLAGS change to arch.mk
On Tue, Aug 24, 2021 at 04:23:22PM +0100, Julien Grall wrote: > Hi Anthony, > > On 24/08/2021 16:00, Anthony PERARD wrote: > > Changes to XEN_LDFLAGS may or may not apply to targets in for > > example "common/" depending on whether one runs `make` or `make > > common/`. > > > > But arch.mk is loaded before doing any build, so changes to LDFLAGS > > there mean that the value of XEN_LDFLAGS won't depends on the > > initial target. > > An explanation in the commit message would be useful. This one you provided > looks good. So: > > Acked-by: Julien Grall <jgrall@xxxxxxxxxx> > > Can it be merged before the previous patch? If so, I can update the commit > message and commit it. Yes, that should be fine, thanks! -- Anthony PERARD
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |