[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/6] arch/x86: rename debug.c to gdbsx.c
- To: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Aug 2021 14:19:58 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xMcInLkTOC6aqL0Kvqwr2p25IHw8varYDATpodJKymI=; b=ka+D7ykkf9fGWq2JkfYx/7VUiyP/mS/+5F9hSwvJ4ZcdDild5zgqrxmdZMNxFJ9dRWkxy5agjWpa56KnbmUmXhf7Jh+cabj6846anu3kYA86RBffNXFymM7ejE7GGaBqEjkivflqj/ACaALO/JxqIaXACm79ITqJdL4tcIItyhPuG05DXCZRJVN+xn0toC1Mja7qS5QTbmCrKCwqJ9d3GVEoIJ4qy7vrET4sDn4SmUiVLv+kASqsll/qZke38Ltsd9ZxBL+Ok7jeoIrMxqA3qiYkuFV63cnzdofwwKYXBTsqAExXDNDvunK3jCpMaUszMSqOFEKAtF2qLJcy+B8ORw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q9+6ih0eL1RpDMrW/qG+RiIjYAUD1h6CbbMWK5+mY3hum3jC7o3HWfinTmh4BimBwEmFIAIQG9RSyiLREn0RMy4S4F1i0QzJl2clYc3oqL0uAyQq93vogvXto8dOD2sJW8yMF9Y6eapimUcsU/P3dN8B4SSAACN0T6ndATBmqbkJVJg6Ar0x0jIM9ONqTf85sCXd/tpgNbECpXerMAdfpZXVwb39N4EvtIIVx9eZKoOOCS/KIa4L7gQpsJOMDOYz5CLc89CYsD+ej3NGW9O/ZP/1lt+pkjxKyAy3q+DquHEdWtR397NkguN3NtBl3NDO7NKLgpczgGJVcCtmRKNQDA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Aug 2021 12:20:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.08.2021 22:29, Bobby Eshleman wrote:
> --- /dev/null
> +++ b/xen/include/asm-x86/gdbsx.h
> @@ -0,0 +1,17 @@
> +#ifndef __X86_GDBX_H
> +#define __X86_GDBX_H__
> +
> +#ifdef CONFIG_GDBSX
> +
> +int gdbsx_guest_mem_io(domid_t domid, struct xen_domctl_gdbsx_memio *iop);
> +
> +#else
> +
> +static inline int gdbsx_guest_mem_io(domid_t domid, struct
> xen_domctl_gdbsx_memio *iop)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> +#endif
In addition to what Andrew has said, you also want to make sure
- domid_t is actually declared (need to include public/xen.h, I think),
- struct xen_domctl_gdbsx_memio has a forward declaration (ahead of the
#ifdef).
This is so the header can actually be #include-d without needing to
worry about prereq #include-s.
Jan
|
