[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 4/6] x86/gdbsx: expand dbg_rw_mem() inline


  • To: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 24 Aug 2021 12:32:30 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cqj61IAy6MZ17K6/1ZqxTDC5GkKaLjnkao9Mp6K3Auo=; b=U+LcMvOjtCVLats/rPR0HuKYmdOtKy9/LzN9jJ4HyyM5rEu0NbPn7HSprGAvxdnK+ASuN38vPsbXe1Xj7PHM1tqmV0kgDEDv2bgnXgy7mWGgV2AVuZ9i9By6rN7Z4QmZwX7xkJeZu7yyTLcNiQrHxA6B+0d/Q+nlc12sh4TcjFBWeE4SpfahGe4rKOb11d2NTJphuEgpIgvIvNfA3ioWPzfOlarGJyGB3XE+PIMvt66nFYPxNkch5SQQOBM63D0zFvurffXTmSRJupcFFCtzHa560dET87KP1lWNIGl3WLVLUTnsTXWUaDoNXvPVX0egOFnCiM2KsoAEb+qBp1USfw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ge5l5VtOpO0p3cg90H5LZ7paQOLsipBv9fCDBPzMwZ6ruo2urhOdvRcfxIzqavAjAHCG6xmKJATcqTR4ZGcwxUG0X+fNufwNWkP7zIqv6a1lu/azQjduQmRtNM9B64P5Y+k+qtwt7GE6ikoTe0tfgNHeCVSvzo6DehrgDe7aLP6REAKYwHZTGmZ8oG1yBgFEjXOQxdrgs04abBKDiNNoMOHkYryJBgR5r/aauAit62Lrtl29LsMN606PDjuF8vSPiQRc8i8fR7uDzm4G8e/6jh8fgUtnQCQnEQy0Akgpc4wBIJn0EEKTecWQk3TmmveUlbAzV1zF4zHMNTyK5RSVCw==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • Delivery-date: Tue, 24 Aug 2021 11:32:47 +0000
  • Ironport-hdrordr: A9a23:XilJZKPTpgV2pMBcT0T155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjztSWUtN4QMEtQ/exoS5PwPk80kqQFnbX5XI3SITUO3VHHEGgM1/qb/9SNIVyZygcZ79 YbT0EcMqyBMbEZt7eC3ODQKb9Jq7PmgcPY99s2jU0dKj2CA5sQnjuRYTzrcHGeKjM2YKbRWK Dsnfau8FGbCAoqh4mAdzc4t6+pnay8qLvWJTo9QzI34giHij2lrJb8Dhijxx8bFxdC260r/2 TpmxHwovzLiYD69jbsk0voq7hGktrozdVOQOSKl8guMz3pziKlfp5oVbGutC085Muv9FEput /RpApIBbUz11rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ff0QTorYvAxyL5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqvlDcmwtmrccjy1hkFacOYr5YqoISuGlPFo0bIS784Ic7VM FzEcDn4upMe1/yVQGagoBW+q3qYp0PJGbBfqBb0fbligS+3UoJjHfw/fZv2kvpr/kGOsF5D4 2uCNUaqFlMJvVmJ56VSt1xGvdepwT2MFvx2VmpUCDa/Zc8SjnwQq7MkcAIDd6RCes1JbsJ6d j8uQBjxCEPk3yHM7zH4HQMyGGWfFmA
  • Ironport-sdr: wp78ZzSYFOuM9vN0jSmD6r18jW5ikuBg80+2BOnU3dHst/ZDRvwWnWFR2Vi+tGibYdvIfyBooC APh+PdLfCuXxFyWjbs6a6J1FTwqmLpPkLz33Z328bSj3yrcL1yIT6IvJtaKcrw9UOjbhGTjwgr cggobqRFVgoGtpBtbqjtWVZ33noPtctbYYpByvsU24XxI6bCSioGmxQghEVS51QJGPmkbaDw+4 Q36RkhOy4i/TK0RF8X10XKRouOqfr0xCbN097pd2YQE7wMxiC84r6XVmAOuYMZ0PuZ836niiyz qNHP/4yjZz8vvzwoJk4RE6Ai
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18/08/2021 21:29, Bobby Eshleman wrote:
> Because dbg_rw_mem() has only a single call site, this commit
> expands it inline.

Missing a SoB.

Otherwise, looks ok.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.