[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/bitmap: Don't open code DIV_ROUND_UP()
- To: Jane Malalane <jane.malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 11 Aug 2021 17:39:59 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vex7xXiURIoZrr3tbOgfQTP5BlYPm1n/DRPu02KIjvg=; b=UHCHIdfdvTCA5mnqDysYS+QF91M2bj7QN+o1HsZWWmhxNh/8cfOQ9OXQoRqUMPuLnbwa1M22t2LAau2kyTuXGuQxN5yoPvpdxLaXX9wur181bUaohfhhtK86trpE6GF80nRtye+s5v9JNd2YcXKsGdYVtotR8zHejqDpqPgOuSPhy+DVNPzAPrrTm33pvddly1BC08u7HtC4wqz/BUZduCM8hlgQXV/VIOC+9jawcwBBqLaYa3choJH1ac3c3sM0czkQTEwiPw7mR+CdB/z7wYKuR1ad/pN6SWUydgPO5h3mI2u6uWH+6wi7z2fV1dc/0Bpg4HfGGj7yXe6OfTK/Sg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hRYYPnaf6z1qNRczi+PvoINT7BJumtW2phC4Ke77ItAgdK47GYT0SPdGuq2RnxU+l9oEDRTqBlBoz16Dh+UkOKpWGvit1qcHFrw+lMNkPDJAITuBsVJZlBc1TGn4z37768ySBQcnkqI8CFiVTO1qZ+yf2AskTuBfHX+ifpza0e5ezc99gqDGpLHIRrg5cVxXpXq2eciMwGaZu32jKOt6i73tFzh5Mbvmf83/OA5WZ+25nyiqCMT8whnyeZKhdczpm658HnqNcJMksgucOPaXE8xjAgTRiUkRA7KzmVBO9Iyz7HW8dDfKGoDD4OgHKZ28AUnWWLme1V3ITNODPH7TAw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 11 Aug 2021 15:40:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.08.2021 17:20, Jane Malalane wrote:
> --- a/xen/common/bitmap.c
> +++ b/xen/common/bitmap.c
> @@ -10,6 +10,7 @@
> #include <xen/bitmap.h>
> #include <xen/bitops.h>
> #include <xen/cpumask.h>
> +#include <xen/lib.h>
> #include <xen/guest_access.h>
> #include <asm/byteorder.h>
I'm curious how you've chosen this insertion point. While the first
two #include-s (just out of context) are still unsorted, the rest
currently matches our goal of alphabetical sorting (within the
sub-groups, i.e. xen/, asm/, and public/), unless there's an actual
reason to violate this pattern. Hence please don't violate this
partial sorting and move the insertion one line down.
> @@ -338,7 +339,7 @@ EXPORT_SYMBOL(bitmap_allocate_region);
>
> #ifdef __BIG_ENDIAN
>
> -static void bitmap_long_to_byte(uint8_t *bp, const unsigned long *lp, int
> nbits)
> +static void bitmap_long_to_byte(uint8_t *bp, const unsigned long *lp,
> unsigned int nbits)
This now exceeds 80 chars, which is the limit per line. Please wrap
accordingly.
With these taken care of
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
