Re: [PATCH V4 02/10] xen/arm: introduce new helper device_tree_get_meminfo

[Julien Grall <julien@xxxxxxx>]

Hi Penny,

On 28/07/2021 11:27, Penny Zheng wrote:
> A few functions iterate over the device tree property to get memory info,
> like "reg" or "xen,static-mem", so this commit creates a new helper
> device_tree_get_meminfo to extract the
> common codes.
>
> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
Ah, this is where you did the consolidation. Sorry, I didn't notice this 
patch.
In general, we are avoiding to introduce code and then rework it in the 
same series. Instead, the rework is done first and then the function is 
used.
So can you move this patch first?

Cheers,

--
Julien Grall