|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [XEN RFC PATCH 01/40] tools: Fix -Werror=maybe-uninitialized for xlu_pci_parse_bdf
| libxlu_pci.c: In function 'xlu_pci_parse_bdf':
| libxlu_pci.c:32:18: error: 'func' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
| 32 | pcidev->func = func;
| | ~~~~~~~~~~~~~^~~~~~
| libxlu_pci.c:51:29: note: 'func' was declared here
| 51 | unsigned dom, bus, dev, func, vslot = 0;
| | ^~~~
| libxlu_pci.c:31:17: error: 'dev' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
| 31 | pcidev->dev = dev;
| | ~~~~~~~~~~~~^~~~~
| libxlu_pci.c:51:24: note: 'dev' was declared here
| 51 | unsigned dom, bus, dev, func, vslot = 0;
| | ^~~
| libxlu_pci.c:30:17: error: 'bus' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
| 30 | pcidev->bus = bus;
| | ~~~~~~~~~~~~^~~~~
| libxlu_pci.c:51:19: note: 'bus' was declared here
| 51 | unsigned dom, bus, dev, func, vslot = 0;
| | ^~~
| libxlu_pci.c:78:26: error: 'dom' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
| 78 | if ( dom & ~0xff )
| | ~~~~^~~~~~~
Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
---
tools/libs/util/libxlu_pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/libs/util/libxlu_pci.c b/tools/libs/util/libxlu_pci.c
index 551d8e3aed..b38e9aab40 100644
--- a/tools/libs/util/libxlu_pci.c
+++ b/tools/libs/util/libxlu_pci.c
@@ -15,7 +15,7 @@ static int parse_bdf(libxl_device_pci *pci, const char *str,
const char **endp)
{
const char *ptr = str;
unsigned int colons = 0;
- unsigned int domain, bus, dev, func;
+ unsigned int domain = 0, bus = 0, dev = 0, func = 0;
int n;
/* Count occurrences of ':' to detrmine presence/absence of the 'domain' */
@@ -28,7 +28,6 @@ static int parse_bdf(libxl_device_pci *pci, const char *str,
const char **endp)
ptr = str;
switch (colons) {
case 1:
- domain = 0;
if (sscanf(ptr, "%x:%x.%n", &bus, &dev, &n) != 2)
return ERROR_INVAL;
break;
--
2.25.1
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |