[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v6 18/31] xen: move include/asm-* to include/arch-*/asm
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 5 Aug 2021 09:04:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kBlKBEiHbUBBYuvEEBQBsLv3d3jNwgqUNb0n8dMRK/8=; b=kbtdoiITcjwBBbFBKxmMyGHXmQ/FD0vp2dmhnH8GiL9E/peqs2c3iHr80bOUBIvCVJr5MSVWmgLmoeXWwWb9qQy7WAzYV4deNhIzLgWwP3f6hvoJmqyJUiA1kuHUsFlAe7X76IpnhuCJNtCEGIm1OnomrxECdtmHMhmnF3/PP8Xku9/Z5Gwo3yIxb3kIw1PqgekebnjfZ27Y9zZiROl0aX3f3Yt3/GTYRhcqPdxtJEiNVUsQUHw22h2P7PKfRG2smcwlGAwpVe9tnC3Nr4+93TtTLnwI3fCkwyKiBMj845o6u+6nqFZnwWhHW5D8L691YA6i9423O6PF6KsRH7FpRg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xbm55i7F0oeKzS2/aAcXco+2qkAaQRSd0U+GYoxp5K2cGJDZqW+DvCelSBSQqk+I1xb39Ky+jMIGArA+YZNNpHZmxgV5gMIp97eolPOMXkJOOmC4OVyFy/1jT3u+BCpxfWrBvrGXuWn4G1D3ZMw0AqCu9Sq2faFk2MHWVPi1FHqx5pYkqemJneLJ8F1Jdf4u3+pWu+9FXOsgweC1UDxutUmLjr52MTLjPvrFbjaIwTj6zS0tASEpiUJnocixDgP6qKDlPunUaiqZ/8io+sm6lobt+Zvxc8nlWxWk+SP+uWjq0Y0LR4Ufdj/osj3hxFnjcD1UWGM3fxxS7o3DH8690g==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Lukasz Hawrylko <lukasz.hawrylko@xxxxxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 05 Aug 2021 07:04:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.07.2021 16:09, Anthony PERARD wrote:
> This avoid the need to create the symbolic link "include/asm".
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>
> Other possible locations that I could think of:
> include/arch/*/asm
> arch/*/include/asm
I thought it was always the plan to follow Linux (and kind of XTF) in
this regard, using the latter of these options?
> --- a/xen/include/xen/bitmap.h
> +++ b/xen/include/xen/bitmap.h
> @@ -14,7 +14,7 @@
> *
> * Function implementations generic to all architectures are in
> * lib/bitmap.c. Functions implementations that are architecture
> - * specific are in various include/asm-<arch>/bitops.h headers
> + * specific are in various include/arch-<arch>/asm/bitops.h headers
Then, just to take this as an example, referring to just asm/bitops.h
in comments might be enough (limiting churn on some of the ones that
you're altering)?
Jan
|
