[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks
- To: Like Xu <like.xu.linux@xxxxxxxxx>
- From: "Zhu, Lingshan" <lingshan.zhu@xxxxxxxxx>
- Date: Thu, 22 Jul 2021 11:03:44 +0800
- Cc: bp@xxxxxxxxx, seanjc@xxxxxxxxxx, vkuznets@xxxxxxxxxx, wanpengli@xxxxxxxxxxx, jmattson@xxxxxxxxxx, joro@xxxxxxxxxx, kan.liang@xxxxxxxxxxxxxxx, ak@xxxxxxxxxxxxxxx, wei.w.wang@xxxxxxxxx, eranian@xxxxxxxxxx, liuxiangdong5@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, boris.ostrvsky@xxxxxxxxxx, Like Xu <like.xu@xxxxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Guo Ren <guoren@xxxxxxxxxx>, Nick Hu <nickhu@xxxxxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, kvmarm@xxxxxxxxxxxxxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Delivery-date: Thu, 22 Jul 2021 03:04:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 7/21/2021 7:57 PM, Like Xu wrote:
On 16/7/2021 4:53 pm, Zhu Lingshan wrote:
+ } else if (xenpmu_data->pmu.r.regs.cpl & 3)
Lingshan, serious for this version ?
arch/x86/xen/pmu.c:438:9: error: expected identifier or ‘(’ before
‘return’
438 | return state;
| ^~~~~~
arch/x86/xen/pmu.c:439:1: error: expected identifier or ‘(’ before ‘}’
token
439 | }
| ^
arch/x86/xen/pmu.c: In function ‘xen_guest_state’:
arch/x86/xen/pmu.c:436:9: error: control reaches end of non-void
function [-Werror=return-type]
436 | }
| ^
cc1: some warnings being treated as errors
+ state |= PERF_GUEST_USER;
}
forgot to enable XEN build in .config, V9 fixes this will come soon
|
