[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 09/10] xsm: expand the function related macros in dummy.h
On 12.07.2021 22:32, Daniel P. Smith wrote: > With the elimination of switching how dummy.h gets included, the function > declaration macros are no longer necessary. This commit expands them out to > the > only value for which they will ever be set. This results in function > declaration lengths changing and since some definitions did not even follow > the > 80 column wrapping style, all function definitions were aligned with the > predominate style found in core hypervisor code. I'm afraid this last half sentence is quite far from true: > @@ -82,43 +79,43 @@ static always_inline int xsm_default_action( > } > } > > -static XSM_INLINE void dummy_security_domaininfo(struct domain *d, > +static inline void dummy_security_domaininfo(struct domain *d, > struct xen_domctl_getdomaininfo *info) Padding wasn't good here before, but you clearly do not change it to either of the forms we agreed on as being the goal for consistency: static inline void dummy_security_domaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) or static inline void dummy_security_domaininfo( struct domain *d, struct xen_domctl_getdomaininfo *info) . Further down there are enough other examples. > -static XSM_INLINE int dummy_domain_create(XSM_DEFAULT_ARG struct domain *d, > u32 ssidref) > +static inline int dummy_domain_create(struct domain *d, u32 ssidref) When you have to touch lines anyway, may I suggest that you also take the opportunity and convert u<N> to uint<N>_t, to bring this file better in line with ./CODING_STYLE? Jan
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |