[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v4 4/5] tools/libs/gnttab: Fix PAGE_SIZE redefinition error
On 09/07/2021 09:59, Costin Lupu wrote: Hi Julien, Hi Costin, On 7/8/21 8:33 PM, Julien Grall wrote:Hi Costin, On 08/06/2021 13:35, Costin Lupu wrote:If PAGE_SIZE is already defined in the system (e.g. in /usr/include/limits.h header) then gcc will trigger a redefinition error because of -Werror. This patch replaces usage of PAGE_* macros with XC_PAGE_* macros in order to avoid confusion between control domain page granularity (PAGE_* definitions) and guest domain page granularity. The exception is in osdep_xenforeignmemory_map() where we need the system pageDid you mean osdep_gnttab_grant_map?Argh, yes, sorry about that. Can we fix this on upstreaming or should I send a new version? I can do it on commit. Cheers, size to check whether the PFN array should be allocated with mmap() or with dynamic allocation. Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>Other than the question above: Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>Cheers, Costin -- Julien Grall
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |