[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
- Date: Thu, 8 Jul 2021 02:14:28 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u+uE/GoEh5pA47/oqCoiIZu3SZACAEBjH1E1VYzbE74=; b=CUvhvOfYOAL8p6xBenIiWsznlQziw8wAt1enhCAmZY79pBzPcdyNqTAO92n0KhC+NIDbtviQRQS+AbTYDI9zkbKM1B1f/dxltAySXfQx/9VAHTfYObtrDbavSl5lcTpcyr/zO95k9HtcVWOnxt3/AfVVVdQ0ISIq3R05tcNUR9aFAd/voebGOIGuDa6UJX2AvBDmQb5Ymrd975hXzqtvRmBx/RBL8oYT8Qw7vM13gOsP67QuLIdM+EeYNrKCA1HaxsViC0q9qX8G6u9coa0mdBxUNtaoKm2n/i1xckbg61SKdv+dmF4uAL6uCvZ9v0dF0pVefWp0mfXw0pKOBH3hMw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QEWTiu25+uQ5HUexNW6UlJOFdWqvhmqUJc45RsibWoapr3SdWbYSMZBmDWFq3AKC3zyQdE8UgsPmf4oHPBpfVU0yflSKbMbDxZ71+6ruPWKXGWpAmmb8LcSYrcqBM2Ng5ywoYk8csBDH1r+dnoZwt1thp2VVxbdha2o9lq7i6dv1/dUbe1gRHVHuiUOf9WeiCuWpUyOYQAP6XGl1wE1AVDyNbYh7ijCnWW6mxZmcQfQ8Cli34PAFgG2XNR6R7sdvB8CMZkkWn6CLitZpObmPo/vG6657ou+0C6AVPQD+QGonVRplVNSvPTrKjyFXGYjZcaulL5kbRJoHdQNSVT90zA==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <iwj@xxxxxxxxxxxxxx>, <wl@xxxxxxx>, <george.dunlap@xxxxxxxxxx>, <julien@xxxxxxx>, <sstabellini@xxxxxxxxxx>, <jgross@xxxxxxxx>, <christian.lindig@xxxxxxxxxx>, <dave@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 08 Jul 2021 01:14:47 +0000
- Ironport-hdrordr: A9a23:sTxbaakYTo+cLl0I9Ysxuhu9/t7pDfPCimdD5ihNYBxZY6Wkfp +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPlICPoqTMiftW7dyRWVxeBZnPffKljbehEWmdQtrp uIH5IOceEYSGIK8PoSgzPIYOrIouP3iJxA7N22pxwGIHAIGsMQmjuRSDzrdHGeLDM2dabRf6 Dsg/avyQDQHUj/Iv7LfEXsCIP41qz2fd/dEFE7Li9izDPLoSKj6bb8HRTd9hACUwlXybNn1W TeiQT26oiqrvn+k3bnpi7uxqUTvOGk5spIBcSKhMRQAjLwijywbIAkf7GZpjg6rMym9V5vut jRpBULOdh19hrqDy+IiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ/u1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh7rD3xHklVKvoIRiKr7zOSI JVfYfhDbdtABOnhknizyxSKIfGZAVrIv/uKXJyyPB80FBt7TpEJgUjtZQidtppzuN1d3B+3Z WyDk1frsAEciYnV9MIOA4/e7rANoXse2OADIvAGyWqKEk4U0i946Ifpo9Fv92XRA==
- Ironport-sdr: GQpsNhA0uFDkRYuYQENDswi2iA8K+3SjLbWDIjD5MzXJS6w8gRRuXPDZLbwUF1gYuBKBFkZjSA y2gQnCKrvMixv7BE3eTmhjEV3lxkDH7jBE4vusyP7qoo8WhdPMmmSyuoQuMTFXxXvOKeXfgnfZ EfDLI05/EpPKuU90gHT9NBPB0bYvh9oDduVRrBKHy1UadAiMlcKcVzzXzom1Eb2pyCGwSx6ttU 5AxVXraNMoh8rItL/duyBMEEf4NIPlr86GZIPPoiNVDT3jmq9CyVkY7D9ayt3/YKCXGWh1m66C TlE=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/07/2021 02:11, Andrew Cooper wrote:
On 08/07/2021 02:08, Igor Druzhinin wrote:
On 07/07/2021 10:19, Andrew Cooper wrote:
On 07/07/2021 08:46, Jan Beulich wrote:
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface
*xch,
int xc_domain_irq_permission(xc_interface *xch,
uint32_t domid,
- uint8_t pirq,
+ uint32_t pirq,
uint8_t allow_access);
Take the opportunity and also change "allow_access" to bool? Or is
use of bool prohibited in external interfaces?
We've got bool's in the interface already.
Where exactly? I couldn't find a single "bool".
$ git grep -w bool -- :/tools/include/xen*.h
../tools/include/xenctrl.h:1844: uint32_t
domid, bool restore,
../tools/include/xenctrl.h:1846: unsigned int
nr_features, bool pae, bool itsc,
../tools/include/xenctrl.h:1847: bool
nested_virt, const struct xc_xend_cpuid *xend);
../tools/include/xenctrl.h:1954:int
xc_altp2m_get_domain_state(xc_interface *handle, uint32_t dom, bool *state);
../tools/include/xenctrl.h:1955:int
xc_altp2m_set_domain_state(xc_interface *handle, uint32_t dom, bool state);
and loads more.
Are we ok to have different types in ABI interface and in libxc
function prototype then? Because I was referring to ABI structures.
Igor
|
