[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v6 06/31] x86/mm: avoid building multiple .o from a single .c file
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Jul 2021 16:45:11 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qFIIUHzMTDKCqPL8znK8J92aEXgfwDlYde2CPqpWyPE=; b=lqrz1g0cRiZw2q6gzi5r0wVMwDvcEbMrXSKipJoLTLio4ubCkimLIZVPMP5zYvn1BU5QDOHVUo6oJH8aIxQdEkI8e+hG/DX3qU5y6y98dqLDP0U9EFbmGYo0Yg1SU/fGJW1l2PSbLVgyAUJqnA5jAJZpt/EHu1J8DP5p+nz8MHB2Z8IRDN/fAtqCnU5l2DpzPctCYZc0apgsjb6Ue+dk8D0Q6Df/HYyhein9BeXDV2RMqLpN8IFl1qKRKGOAMPFLjUawLDi4dTd1+EjUmaX60HmHxB4bqtyhM4Bjnzl4tQnnMN4k7HCQH0Ab23+ZT+o9WTjqr9no+NuwdUP7/evKkw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lKKksC+wvz7PMgduTHf7tOOB0ptgDRjiyvXqv7wYJ+2BbaDVxhA5wYNw4dA5OyAj2JYzN2yyavgJTxm8b/gVQnQ3bz+kBzpMExkcBs647cYH7EcTUByEj05GBqKyHgdxg+fe5v63Tb7bYAdXjT5zPthvwIaRa4gGZm9FYCBPe8cgf9gVs60N0e06UPMmR7V9Uulm+cINLArHeSbFBaou2p9r4vsLNu1qTNWdI/qFLU2sSWO6J9WwKaJzOs80pg7mjbo6UectmnuNa5TTIaafa9wP+f3rULHavZa/L14gZk/IumgjH7qMwst0KlS5DbMT3Ptv7d0UTeSbZBQLl+aTsg==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jul 2021 14:45:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.07.2021 16:09, Anthony PERARD wrote:
> This replace the use of a single .c file use for multiple .o file by
> creating multiple .c file including the first one.
>
> There's quite a few issues with trying to build more than one object
> file from a single source file: there's is a duplication of the make
> rules to generate those targets; there is an additional ".file" symbol
> added in order to differentiate between the object files; and the
> tools/symbols have an heuristic to try to pick up the right ".file".
>
> This patch adds new .c source file which avoid the need to add a
> second ".file" symbol and thus avoid the need to deal with those
> issues.
While I have to admit that I'm not really happy about these extra new
files, I can see that one might view this as the less bad of two
evils.
> xen/Makefile | 11 -----------
> xen/Rules.mk | 2 +-
> xen/arch/x86/mm/Makefile | 9 ---------
> xen/arch/x86/mm/guest_walk.c | 3 ---
> xen/arch/x86/mm/guest_walk_2.c | 2 ++
> xen/arch/x86/mm/guest_walk_3.c | 2 ++
> xen/arch/x86/mm/guest_walk_4.c | 2 ++
> xen/arch/x86/mm/hap/Makefile | 9 ---------
> xen/arch/x86/mm/hap/guest_walk.c | 3 ---
> xen/arch/x86/mm/hap/guest_walk_2level.c | 2 ++
> xen/arch/x86/mm/hap/guest_walk_3level.c | 2 ++
> xen/arch/x86/mm/hap/guest_walk_4level.c | 2 ++
Is there a particular reason you've kept the "level" in these three
file names? Preferably with them shortened (and ideally dashes used
everywhere in the new file names instead of underscores)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
