[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] bus: Make remove callback return void
- To: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
- From: Kirti Wankhede <kwankhede@xxxxxxxxxx>
- Date: Tue, 6 Jul 2021 16:46:21 +0530
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=linaro.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gzQgfqIi8OFdMGOA+iDXYHDenSaYbIa98IiQWdAlr00=; b=PbcXlkdCv25iKncBNhz1SQ8QsirUn58/y6c0ZmgRVus/xxMLbQ+eR9VSZ8eS506GpA2/FBfVsZ02guxjIB/XH7j/2OgjjGvg8CvTq+vELmw+UEsn8eda5C/LlejJ5Rvnhlxv9Vq4u8iw3YorMf/V1Kt7r5YEs+kp9iV5eUT8qYCAru8m/eCf7MY/zpu4IWRaIZ7LQCj+ntML2yOrXDI3yBcUIZAzvmFL4gVKSV5hmxR2vbloCwGfZAqDrgsHFQlNeRuHorr7BxChRkbtg6OF6BJIuRJ0pDWVaA3/LNo3ycmIeKRljLZTyAL1xlaE4oBbreAYAPZoCo0uQol2wsMRJw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OB3jt3SlsdowvqILnghDEybT9vYvyo2iso3STBIJcnupZGT9eEg2Qnje2DqSc1C4mFk2QBNm4Rucxdtyl+OsHUQ/EmMhpY6Ao22yIbNMM+gvlQ8sod5DJX/bxsjpKS6eO4jX3PQu/YQHrM1O+BbrVNmmvyE+/SEjOD6yYppVXkhGxNBjW6Ktv0JvCMebYgktbnIi00Q7kZfMtMhgzlS+RanZh8R3z7epBj+pipCPB70e3UOOw6Nwz1UsTwZdygf++CmCNg4iCcEFQob/F8pbAQCy3wJJMjqKQPM3zCAKa0XQ42hESmNJRNH+Vc9ZPSJZpZVoJ4lnNlD0tHOjILD6vg==
- Cc: <kernel@xxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Geoff Levand <geoff@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, William Breathitt Gray <vilhelm.gray@xxxxxxxxx>, Rafał Miłecki <zajec5@xxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Chen-Yu Tsai <wens@xxxxxxxx>, Jernej Skrabec <jernej.skrabec@xxxxxxxxx>, Alison Schofield <alison.schofield@xxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Ben Widawsky <ben.widawsky@xxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>, Sudeep Holla <sudeep.holla@xxxxxxx>, Cristian Marussi <cristian.marussi@xxxxxxx>, Wu Hao <hao.wu@xxxxxxxxx>, Tom Rix <trix@xxxxxxxxxx>, Moritz Fischer <mdf@xxxxxxxxxx>, Jiri Kosina <jikos@xxxxxxxxxx>, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>, Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>, Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>, Johannes Thumshirn <morbidrsa@xxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Maxim Levitsky <maximlevitsky@xxxxxxxxx>, Alex Dubov <oakad@xxxxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, Tomas Winkler <tomas.winkler@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jon Mason <jdmason@xxxxxxxx>, Allen Hubbe <allenbh@xxxxxxxxx>, Kishon Vijay Abraham I <kishon@xxxxxx>, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>, Maximilian Luz <luzmaximilian@xxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Mark Gross <mgross@xxxxxxxxxxxxxxx>, Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>, Alexandre Bounine <alex.bou9@xxxxxxxxx>, Ohad Ben-Cohen <ohad@xxxxxxxxxx>, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Thorsten Scherer <t.scherer@xxxxxxxxxxxx>, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>, Andy Gross <agross@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Michael Buesch <m@xxxxxxx>, Sven Van Asbroeck <TheSven73@xxxxxxxxx>, Johan Hovold <johan@xxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, Andreas Noever <andreas.noever@xxxxxxxxx>, Michael Jamet <michael.jamet@xxxxxxxxx>, Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>, Yehezkel Bernat <YehezkelShB@xxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Martyn Welch <martyn@xxxxxxxxxxxx>, Manohar Vanga <manohar.vanga@xxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Tyrel Datwyler <tyreld@xxxxxxxxxxxxx>, Vladimir Zapolskiy <vz@xxxxxxxxx>, Samuel Holland <samuel@xxxxxxxxxxxx>, Qinglang Miao <miaoqinglang@xxxxxxxxxx>, Alexey Kardashevskiy <aik@xxxxxxxxx>, Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>, Joey Pabalan <jpabalanb@xxxxxxxxx>, Pali Rohár <pali@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Frank Li <lznuaa@xxxxxxxxx>, Mike Christie <michael.christie@xxxxxxxxxx>, Bodo Stroesser <bostroesser@xxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, David Woodhouse <dwmw@xxxxxxxxxxxx>, SeongJae Park <sjpark@xxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-mips@xxxxxxxxxxxxxxx>, <linux-parisc@xxxxxxxxxxxxxxx>, <linuxppc-dev@xxxxxxxxxxxxxxxx>, <linux-acpi@xxxxxxxxxxxxxxx>, <linux-wireless@xxxxxxxxxxxxxxx>, <linux-sunxi@xxxxxxxxxxxxxxx>, <linux-cxl@xxxxxxxxxxxxxxx>, <nvdimm@xxxxxxxxxxxxxxx>, <dmaengine@xxxxxxxxxxxxxxx>, <linux1394-devel@xxxxxxxxxxxxxxxxxxxxx>, <linux-fpga@xxxxxxxxxxxxxxx>, <linux-input@xxxxxxxxxxxxxxx>, <linux-hyperv@xxxxxxxxxxxxxxx>, <linux-i2c@xxxxxxxxxxxxxxx>, <linux-i3c@xxxxxxxxxxxxxxxxxxx>, <industrypack-devel@xxxxxxxxxxxxxxxxxxxxx>, <linux-media@xxxxxxxxxxxxxxx>, <linux-mmc@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <linux-ntb@xxxxxxxxxxxxxxxx>, <linux-pci@xxxxxxxxxxxxxxx>, <platform-driver-x86@xxxxxxxxxxxxxxx>, <linux-remoteproc@xxxxxxxxxxxxxxx>, <linux-scsi@xxxxxxxxxxxxxxx>, <alsa-devel@xxxxxxxxxxxxxxxx>, <linux-arm-msm@xxxxxxxxxxxxxxx>, <linux-spi@xxxxxxxxxxxxxxx>, <linux-staging@xxxxxxxxxxxxxxx>, <greybus-dev@xxxxxxxxxxxxxxxx>, <target-devel@xxxxxxxxxxxxxxx>, <linux-usb@xxxxxxxxxxxxxxx>, <linux-serial@xxxxxxxxxxxxxxx>, <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, <kvm@xxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Jul 2021 11:18:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 7/6/2021 3:20 PM, Uwe Kleine-König wrote:
The driver core ignores the return value of this callback because there
is only little it can do when a device disappears.
This is the final bit of a long lasting cleanup quest where several
buses were converted to also return void from their remove callback.
Additionally some resource leaks were fixed that were caused by drivers
returning an error code in the expectation that the driver won't go
away.
With struct bus_type::remove returning void it's prevented that newly
implemented buses return an ignored error code and so don't anticipate
wrong expectations for driver authors.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
drivers/vfio/mdev/mdev_driver.c | 4 +---
Acked-by: Kirti Wankhede <kwankhede@xxxxxxxxxx>
|