[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH] tools/libxenguest: Fix migration's debug option
The code has gone through many refactors, but the first refactor was the one which broke it by inverting the check with respect to checkpointed streams. Fixes: 7449fb36c6c8 ("migration/save: pass checkpointed_stream from libxl to libxc") Reported-by: Olaf Hering <olaf@xxxxxxxxx> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> --- CC: Ian Jackson <iwj@xxxxxxxxxxxxxx> CC: Wei Liu <wl@xxxxxxx> CC: Olaf Hering <olaf@xxxxxxxxx> `xl migrate --debug` might not be perfect, but this at least brings it back to mostly working. I don't think dropping it is a sensible move. In particular, it is invaluable for testing the logdirty infrastructure when migrating a memtest VM. If anyone has a clever idea to fix the grant problem, then we can. It is after all a debug option, without any specific prescribed behaviour. --- tools/libs/guest/xg_sr_save.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c index 2ba7c3200cd5..f0e2bd048d37 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -752,7 +752,7 @@ static int send_domain_memory_live(struct xc_sr_context *ctx) if ( rc ) goto out; - if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN ) + if ( ctx->save.debug && ctx->stream_type == XC_STREAM_PLAIN ) { rc = verify_frames(ctx); if ( rc ) -- 2.11.0
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |