Re: [PATCH] tools/xenstored: Correctly read the requests header from the stream

[Julien Grall <julien@xxxxxxx>]

Hi,

On 25/06/2021 08:58, Juergen Gross wrote:
> On 25.06.21 08:45, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > Commit c0fe360f42 ("tools/xenstored: Extend restore code to handle
> > multiple input buffer") extend the read_buffered_state() to support
> > multiple input buffers. Unfortunately, the commit didn't go far
> > enough and still used sc->data (start of the buffers) for retrieving
> > the header. This would lead to read the wrong headers for second and
> > follow-up commands.
> >
> > Use data in place for sc->data for the source of the memcpy()s.
> >
> > Fixes: c0fe360f42 ("tools/xenstored: Extend restore code to handle 
> > multiple input buffer")
> > Reported-by: Raphael Ning <raphning@xxxxxxxxxx>
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Thank you! I have committed the patch.

Cheers,

> Juergen
--
Julien Grall