[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/30] mtd_blkdevs: use blk_mq_alloc_disk
- To: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Tue, 15 Jun 2021 17:58:17 +0200
- Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Justin Sanders <justin@xxxxxxxxxx>, Denis Efremov <efremov@xxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Tim Waugh <tim@xxxxxxxxxxxx>, Geoff Levand <geoff@xxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Maxim Levitsky <maximlevitsky@xxxxxxxxx>, Alex Dubov <oakad@xxxxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
- Delivery-date: Tue, 15 Jun 2021 15:58:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jun 15, 2021 at 05:47:44PM +0200, Marek Szyprowski wrote:
> Hi,
>
> On 02.06.2021 08:53, Christoph Hellwig wrote:
> > Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue
> > allocation.
> >
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> This patch landed in linux-next as commit 6966bb921def ("mtd_blkdevs:
> use blk_mq_alloc_disk"). It causes the following regression on my QEMU
> arm64 setup:
Please try the patch below:
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 5dc4c966ea73..6ce4bc57f919 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -382,6 +382,7 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
}
new->disk = gd;
+ new->rq = new->disk->queue;
gd->private_data = new;
gd->major = tr->major;
gd->first_minor = (new->devnum) << tr->part_bits;
|
