[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH V3 08/11] swiotlb: Add bounce buffer remap address setting function
 
- To: Robin Murphy <robin.murphy@xxxxxxx>
 
- From: Christoph Hellwig <hch@xxxxxx>
 
- Date: Mon, 14 Jun 2021 17:32:52 +0200
 
- Cc: Christoph Hellwig <hch@xxxxxx>, Tianyu Lan <ltykernel@xxxxxxxxx>,	kys@xxxxxxxxxxxxx, haiyangz@xxxxxxxxxxxxx, sthemmin@xxxxxxxxxxxxx,	wei.liu@xxxxxxxxxx, decui@xxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx,	mingo@xxxxxxxxxx, bp@xxxxxxxxx, x86@xxxxxxxxxx, hpa@xxxxxxxxx,	arnd@xxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, luto@xxxxxxxxxx,	peterz@xxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx,	kirill.shutemov@xxxxxxxxxxxxxxx, rppt@xxxxxxxxxx,	hannes@xxxxxxxxxxx, cai@xxxxxx, krish.sadhukhan@xxxxxxxxxx,	saravanand@xxxxxx, Tianyu.Lan@xxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx,	m.szyprowski@xxxxxxxxxxx, boris.ostrovsky@xxxxxxxxxx,	jgross@xxxxxxxx, sstabellini@xxxxxxxxxx, joro@xxxxxxxxxx,	will@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx,	davem@xxxxxxxxxxxxx, kuba@xxxxxxxxxx, jejb@xxxxxxxxxxxxx,	martin.petersen@xxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx,	linux-arch@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx,	linux-kernel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx,	netdev@xxxxxxxxxxxxxxx, vkuznets@xxxxxxxxxx,	thomas.lendacky@xxxxxxx, brijesh.singh@xxxxxxx,	sunilmut@xxxxxxxxxxxxx
 
- Delivery-date: Mon, 14 Jun 2021 15:33:04 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On Mon, Jun 14, 2021 at 02:49:51PM +0100, Robin Murphy wrote:
> FWIW, I think a better generalisation for this would be allowing 
> set_memory_decrypted() to return an address rather than implicitly 
> operating in-place, and hide all the various hypervisor hooks behind that.
Yes, something like that would be a good idea.  As-is
set_memory_decrypted is a pretty horribly API anyway due to passing
the address as void, and taking a size parameter while it works in units
of pages.  So I'd very much welcome a major overhaul of this API.
 
 
    
     |