[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 01/14] swiotlb: Refactor swiotlb init functions
 
- To: Claire Chang <tientzu@xxxxxxxxxxxx>
 
- From: Christoph Hellwig <hch@xxxxxx>
 
- Date: Mon, 14 Jun 2021 08:16:44 +0200
 
- Cc: Rob Herring <robh+dt@xxxxxxxxxx>, mpe@xxxxxxxxxxxxxx,	Joerg Roedel <joro@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>,	Frank Rowand <frowand.list@xxxxxxxxx>,	Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>,	boris.ostrovsky@xxxxxxxxxx, jgross@xxxxxxxx,	Christoph Hellwig <hch@xxxxxx>,	Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>,	benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx,	"list@xxxxxxx:IOMMU DRIVERS" <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>,	sstabellini@xxxxxxxxxx, Robin Murphy <robin.murphy@xxxxxxx>,	grant.likely@xxxxxxx, xypron.glpk@xxxxxx,	Thierry Reding <treding@xxxxxxxxxx>, mingo@xxxxxxxxxx,	bauerman@xxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx,	Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>,	Saravana Kannan <saravanak@xxxxxxxxxx>,	"Rafael J . Wysocki" <rafael.j.wysocki@xxxxxxxxx>,	heikki.krogerus@xxxxxxxxxxxxxxx,	Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>,	Randy Dunlap <rdunlap@xxxxxxxxxxxxx>,	Dan Williams <dan.j.williams@xxxxxxxxx>,	Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>,	linux-devicetree <devicetree@xxxxxxxxxxxxxxx>,	lkml <linux-kernel@xxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx,	xen-devel@xxxxxxxxxxxxxxxxxxxx,	Nicolas Boichat <drinkcat@xxxxxxxxxxxx>,	Jim Quinlan <james.quinlan@xxxxxxxxxxxx>, tfiga@xxxxxxxxxxxx,	bskeggs@xxxxxxxxxx, bhelgaas@xxxxxxxxxx, chris@xxxxxxxxxxxxxxxxxx,	daniel@xxxxxxxx, airlied@xxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx,	intel-gfx@xxxxxxxxxxxxxxxxxxxxx, jani.nikula@xxxxxxxxxxxxxxx,	jxgao@xxxxxxxxxx, joonas.lahtinen@xxxxxxxxxxxxxxx,	linux-pci@xxxxxxxxxxxxxxx, maarten.lankhorst@xxxxxxxxxxxxxxx,	matthew.auld@xxxxxxxxx, rodrigo.vivi@xxxxxxxxx,	thomas.hellstrom@xxxxxxxxxxxxxxx
 
- Delivery-date: Mon, 14 Jun 2021 06:16:56 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On Fri, Jun 11, 2021 at 11:26:46PM +0800, Claire Chang wrote:
> +     spin_lock_init(&mem->lock);
> +     for (i = 0; i < mem->nslabs; i++) {
> +             mem->slots[i].list = IO_TLB_SEGSIZE - io_tlb_offset(i);
> +             mem->slots[i].orig_addr = INVALID_PHYS_ADDR;
> +             mem->slots[i].alloc_size = 0;
> +     }
> +
> +     if (memory_decrypted)
> +             set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
> +     memset(vaddr, 0, bytes);
We don't really need to do this call before the memset.  Which means we
can just move it to the callers that care instead of having a bool
argument.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
 
    
     |