[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 20/30] nullb: use blk_mq_alloc_disk
 
- To: Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx>
 
- From: Christoph Hellwig <hch@xxxxxx>
 
- Date: Tue, 8 Jun 2021 07:39:05 +0200
 
- Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>,	Justin Sanders <justin@xxxxxxxxxx>,	Denis Efremov <efremov@xxxxxxxxx>,	Josef Bacik <josef@xxxxxxxxxxxxxx>, Tim Waugh <tim@xxxxxxxxxxxx>,	Geoff Levand <geoff@xxxxxxxxxxxxx>,	Ilya Dryomov <idryomov@xxxxxxxxx>,	"Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>,	Jack Wang <jinpu.wang@xxxxxxxxx>,	"Michael S. Tsirkin" <mst@xxxxxxxxxx>,	Jason Wang <jasowang@xxxxxxxxxx>,	Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>,	Roger Pau Monné <roger.pau@xxxxxxxxxx>,	Mike Snitzer <snitzer@xxxxxxxxxx>,	Maxim Levitsky <maximlevitsky@xxxxxxxxx>,	Alex Dubov <oakad@xxxxxxxxx>,	Miquel Raynal <miquel.raynal@xxxxxxxxxxx>,	Richard Weinberger <richard@xxxxxx>,	Vignesh Raghavendra <vigneshr@xxxxxx>,	Heiko Carstens <hca@xxxxxxxxxxxxx>,	Vasily Gorbik <gor@xxxxxxxxxxxxx>,	Christian Borntraeger <borntraeger@xxxxxxxxxx>,	"dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>,	"linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>,	"nbd@xxxxxxxxxxxxxxxx" <nbd@xxxxxxxxxxxxxxxx>,	"linuxppc-dev@xxxxxxxxxxxxxxxx" <linuxppc-dev@xxxxxxxxxxxxxxxx>,	"ceph-devel@xxxxxxxxxxxxxxx" <ceph-devel@xxxxxxxxxxxxxxx>,	"virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx" <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>,	"xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>,	"linux-mmc@xxxxxxxxxxxxxxx" <linux-mmc@xxxxxxxxxxxxxxx>,	"linux-mtd@xxxxxxxxxxxxxxxxxxx" <linux-mtd@xxxxxxxxxxxxxxxxxxx>,	"linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>
 
- Delivery-date: Tue, 08 Jun 2021 05:39:19 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On Thu, Jun 03, 2021 at 12:10:09AM +0000, Chaitanya Kulkarni wrote:
> > diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> > index d8e098f1e5b5..74fb2ec63219 100644
> > --- a/drivers/block/null_blk/main.c
> > +++ b/drivers/block/null_blk/main.c
> > @@ -1851,13 +1851,12 @@ static int null_add_dev(struct nullb_device *dev)
> >  
> >             rv = -ENOMEM;
> 
> Is above initialization needed ?
It isn't strictly required any more.
 
 
    
     |