Re: [PATCH 04/13] cpufreq: Add Hardware P-State (HWP) driver

[Jan Beulich <jbeulich@xxxxxxxx>]

On 26.05.2021 16:59, Jan Beulich wrote:
> On 03.05.2021 21:28, Jason Andryuk wrote:
>> +static void hdc_set_pkg_hdc_ctl(bool val)
>> +{
>> +    uint64_t msr;
>> +
>> +    if ( rdmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) )
>> +    {
>> +        hwp_err("error rdmsr_safe(MSR_IA32_PKG_HDC_CTL)\n");
> 
> I'm not convinced of the need of having such log messages after
> failed rdmsr/wrmsr, but I'm definitely against them getting logged
> unconditionally. In verbose mode, maybe.

Perhaps not even there, considering that recovery from faults gets
logged already anyway (see extable_fixup()), and is suitably
restricted to debug builds.

Jan