Re: [PATCH 2/2] automation: fix dependencies on openSUSE Tumbleweed containers

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Tue, 2021-05-18 at 16:33 +0200, Dario Faggioli wrote:
> On Tue, 2021-05-18 at 15:20 +0200, Roger Pau Monné wrote:
> > On Tue, May 18, 2021 at 02:04:13PM +0200, Dario Faggioli wrote:
> > > From: Dario Faggioli <dario@xxxxxxxxxxxxxxxx>
> > > 
> Mmm... this email address does not really exist, and it's a mistake
> that it ended up here. :-/
> 
> > > Fix the build inside our openSUSE Tumbleweed container by using
> > > the proper python development packages (and adding zstd headers).
> > > 
> > > Signed-off-by: Dario Faggioli <dfaggioli@xxxxxxxx>
> > > ---
> > > Cc: Doug Goldstein <cardoe@xxxxxxxxxx>
> > > Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> > > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > > ---
> > >  .../build/suse/opensuse-tumbleweed.dockerfile      |    5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile
> > > b/automation/build/suse/opensuse-tumbleweed.dockerfile
> > > index 8ff7b9b5ce..5b99cb8a53 100644
> > > --- a/automation/build/suse/opensuse-tumbleweed.dockerfile
> > > +++ b/automation/build/suse/opensuse-tumbleweed.dockerfile
> > > 
> > > @@ -56,10 +57,8 @@ RUN zypper install -y --no-recommends \
> > >          pandoc \
> > >          patch \
> > >          pkg-config \
> > > -        python \
> > >          python-devel \
> > > -        python3 \
> > > -        python3-devel \
> > > +        python38-devel \
> > 
> > When I tested python3-devel was translated into python38-devel, 
> > 
> Oh, really? And when was it that you tested it, if I can ask?
> 
> > which
> > I think is better as we don't need to modify the docker file for
> > every
> > new Python version?
> > 
> That would definitely be better. Right now, I don't see any
> python3-devel package. If python3-devel can still be used (and it
> somehow translates to the proper -devel package), then sure we should
> use it. I'm not sure how that would happen, but maybe it's just me
> being unaware of some packaging magic.
> 
> Let me put "python3-devel" there and test locally again, so we know
> if
> it actually works.
> 
Ok, indeed it works. And, on a second though, it's not obscure at all
that it does.

It's just that python38-devel _provides_ python3-devel, which makes a
lot of sense, and it was silly of me to not think it does that and use
just python3-devel in the first place:

dario@4b10a592ca98:~> zypper if --provides python38-devel
Information for package python38-devel:                                         
                                                                                
                                                                              
---------------------------------------                                         
                                                                                
                                                                              
Repository     : @System                                                        
                                                                                
                                                                              
Name           : python38-devel                                                 
                                                                                
                                                                              
Version        : 3.8.10-1.2
Arch           : x86_64
Vendor         : openSUSE
Installed Size : 882.7 KiB
Installed      : Yes
Status         : up-to-date
Source package : python38-core-3.8.10-1.2.src
Summary        : Include Files and Libraries Mandatory for Building Python 
Modules
[...]
Provides       : [8]
    libpython3.so()(64bit)
    pkgconfig(python-3.8) = 3.8
    pkgconfig(python-3.8-embed) = 3.8
    pkgconfig(python3) = 3.8
    pkgconfig(python3-embed) = 3.8
    python3-devel = 3.8.10
    python38-devel = 3.8.10-1.2
    python38-devel(x86-64) = 3.8.10-1.2

What now puzzles me a little, though, is why the build was failing, as
python3-devel was already there in the docker file. Maybe we "just"
forgot to push the image?

Well, there's a different issue (missing libzstd-devel), so I'll send a
v2 of this series anyway.

Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part