[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/5] xen/char: Default HAS_NS16550 to y only for X86 and ARM
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Connor Davis <connojdavis@xxxxxxxxx>
- Date: Mon, 17 May 2021 17:43:31 -0600
- Cc: Bobby Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair23@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 17 May 2021 23:43:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/17/21 5:56 AM, Jan Beulich wrote:
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -1,6 +1,6 @@
config HAS_NS16550
bool "NS16550 UART driver" if ARM
- default y
+ default y if (ARM || X86)
... this approach doesn't scale very well. You would likely have
been hesitant to add a, say, 12-way || here if we had this many
architectures already. I think you instead want
config HAS_NS16550
bool "NS16550 UART driver" if ARM
+ default n if RISCV
default y
which then can be adjusted back by another one line change once
the driver code actually builds.
Jan
Agreed, I will update this in the next version.
Thanks,
Connor
|
