Re: [PATCH v3 15/15] unzstd: make helper symbols static

[Jan Beulich <jbeulich@xxxxxxxx>]

On 15.04.2021 14:09, Julien Grall wrote:
> On 26/01/2021 09:53, Jan Beulich wrote:
>> While for the original library's purposes these functions of course want
>> to be externally exposed, we don't need this, and we also don't want
>> this both to prevent unintended use and to keep the name space tidy.
>> (When functions have no callers at all, wrap them with a suitable
>> #ifdef.) This has the added benefit of reducing the resulting binary
>> size - while this is all .init code, it's still desirable to not carry
>> dead code.
> 
> So why do we keep the code if it is not used? Do you expect it to be 
> re-used in the future?

I expect future patch imports from Linux to be easier to apply when the
code is at least fundamentally the same as what we took from there
originally.

Jan