Re: [PATCH v2 3/6] tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any()

[Juergen Gross <jgross@xxxxxxxx>]

On 13.04.21 17:00, Christian Lindig wrote:
> > On 12 Apr 2021, at 16:22, Juergen Gross <jgross@xxxxxxxx 
> > <mailto:jgross@xxxxxxxx>> wrote:
> > Instead of open coding the mapping of the p2m list use the already
> > existing xc_core_arch_map_p2m() call, especially as the current code
> > does not support guests with the linear p2m map. It should be noted
> > that this code is needed for colo/remus only.
> > [..]
> > diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c 
> > b/tools/ocaml/libs/xc/xenctrl_stubs.c
> > index d05d7bb30e..6e4bc567f5 100644
> > --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
> > +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
> > @@ -32,6 +32,7 @@
> >
> > #define XC_WANT_COMPAT_MAP_FOREIGN_API
> > #include <xenctrl.h>
> > +#include <xenguest.h>
> > #include <xen-tools/libs.h>
> >
> > #include "mmap_stubs.h"
> > —
> > 2.26.2
> Do we need this when there are no other changes in the file?
Yes. Some definitions moved from xenctrl.h into xenguest.h.

> Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx 
> <mailto:christian.lindig@xxxxxxxxxx>>
Thanks,

Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature