Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

[Jan Beulich <jbeulich@xxxxxxxx>]

On 07.04.2021 10:42, Luca Fancellu wrote:
> Just to be sure that we are in the same page, are you suggesting to modify 
> the name
> In this way?
> 
> struct gnttab_cache_flush {
> -    union {
> +    union xen_gnttab_cache_flush_a {
>         uint64_t dev_bus_addr;
>         grant_ref_t ref;
>     } a;
> 
> Following this kind of pattern: xen_<upper struct name>_<member name> ?

While in general I would be fine with this scheme, for field names like
"a" or "u" it doesn't fit well imo. I'm also unconvinced this would be
scalable to the case where there's further struct/union nesting.

Jan