[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/14] tools/firmware: hvmloader: Use const in __bug() and __assert_failed()
- To: Julien Grall <julien@xxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 6 Apr 2021 09:29:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GC/Nd7vUo+zO40AkbW/KhsU7bPjZbbPFHxSbzenE5pk=; b=VxXRH+0OapZcWHOFHNG7XGXzFeLyLJYKIa+EppdYa0uuiS16qwJsm056KFLzzW56ZUrYsSQw1RhHepTLFXWSGTSkskjGixg4YUyUEhwl1qJSYYDv14kGNfeTMZpK7E+Ag1lWIzwZzV3qzgMdfj2YUqkc4RHougAOD77Bs3tD74EFABSoEA8xni0wV3XosS0Tyr1BKCtmO3SWlvH7Rj8aPDhBDDxhdVQomIOecWvBE/GF/HQ/Ih+CVQadzMqPwh7YQc/jA4LMulab0ENNHk/YNd4FMvomufPpuXS11rvkIiAQSWallZqShb0PUysG8NSUaniRMeTf4PLGY8Hid9Di6Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AlG9DxylwRe43blyWG4UQnRgTrRB5NdYCRXzYTYFDB7PHyz2OZGzO0YjMSyXeSB5BuUf9YACwvH7W1QDSiSLia+Njgt0fkOpEZS3vbZ6UvQsLsHRLkfXYe7D4BxSMsEzWxpSI8xjOMQS1E98L+6PcGRCGCQ/H6frqnDeRnncYp/2F4P+bBtgrxE/0Oy/cev9kXBDGhpMYpxyjbHX0QODSAz9pJoh8kLZlbWv+MDpFUM10E5s9iHhKlCZ+VhbUcLEZ3fBmxQV2TODA1poV4CzpsjV3vIpgDo3mh6McLMkAq85hztDe5p7jp/4IT25bLYOLUta2ionzsOzUYksl1a63w==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Apr 2021 07:29:33 +0000
- Ironport-hdrordr: A9a23:vr2Yba2rJPzdM5SwsIN/MwqjBE0kLtp033Aq2lEZdDV+dMuEm8 ey2MkKzBOcsloscVwDufTFAqmPRnvA6YV4iLN7AZ6OVBTr0VHGEKhM9o3nqgePJwTb+vRG3a ltN4hSYeeAbmRSqcb/7E2GH807wN+BmZrIuc7kw31gTR5nZshbhm8SZzqzKFF8RwVNGPMCZf ihz/dAzgDBRV0nKui9G3kZT6ziirTw5fbbSC9DPTBixCmi5AnYjYLHLw==
- Ironport-sdr: N/DowTvzGPe2tJNuA73e7yFPMSJNXsXjwiWLTQQaQZfb9p0B/8tlpEfJu3iGf5auscHR259JCj DFjGbn+MpGNzxmcf1hoKMdQMzt6VMSCBaH5IMxbSDYrIqCT2/z6m4HEDSPZbE9SVgmxWRNMrb1 3Q5DrzKlfhTwEt7HD+Qq9TtQuBw0VJDWAWzFhQH1ZEgZR+l72K4CzuvDp7qdCnmyR1bX2ekOnp ENMLlvkRhfhYd037IzVJE09xszbYAZUVQbSuGX6Amd+C9YhKXdt2c0ld6OSnvyTpdJwnxXR3uI wY0=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Apr 05, 2021 at 04:57:07PM +0100, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> __bug() and __assert_failed() are not meant to modify the string
> parameters. So mark them as const.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
While looking at this I think we should also make the line parameter
unsigned, but again doesn't need to be part of this patch.
Thanks, Roger.
|
