[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation
On 29.03.2021 18:06, George Dunlap wrote: > > >> On Mar 25, 2021, at 1:58 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote: >> >> On 25.03.2021 10:37, Andrew Cooper wrote: >>> On 25/03/2021 09:04, George Dunlap wrote: >>>>> On Mar 25, 2021, at 7:57 AM, Jan Beulich <jbeulich@xxxxxxxx> wrote: >>>>> On 24.03.2021 17:44, George Dunlap wrote: >>>>>> --- a/CHANGELOG.md >>>>>> +++ b/CHANGELOG.md >>>>>> @@ -14,6 +14,8 @@ The format is based on [Keep a >>>>>> Changelog](https://keepachangelog.com/en/1.0.0/) >>>>>> - Named PCI devices for xl/libxl >>>>>> - Support for zstd-compressed dom0 kernels >>>>>> - Library improvements from NetBSD ports upstreamed >>>>>> + - x86_emulate: Support AVX-VNNI instructions >>>>>> + - x86_emulate: Expanded testing for several instruction classes >>>>> TBH both seem too minor to me to be mentioned here. If I was to pick >>>>> just one, I'd keep the former and drop the latter. >>>> It’s always quite difficult in these releases to help express to people >>>> exactly what’s happened. We’ve got over 1000 changesets — what have we >>>> been doing? If my star chart is correct, the latter represents nearly >>>> 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c. It’s >>>> actually a reasonable chunk of code churn, which I think is worth >>>> highlighting. >>> >>> I agree with Jan. New concrete instruction groups are useful for an end >>> user to read. "We refactored some internal of a test harness" isn't, >>> especially when it would most likely be repeated every release. >>> >>> I'd drop the latter line and just keep the former. >> >> And then perhaps also not focus on the emulator, but merely on the >> fact that guests now can use that ISA extension (for which the >> emulator change is a [the only] prereq)? > > Would you mind giving a concrete suggestion? x86: Allow domains to use AVX-VNNI instructions Jan
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |