Re: [PATCH v2 3/3] x86/hpet: Restore old configuration if Legacy Replacement mode doesn't help

[Jan Beulich <jbeulich@xxxxxxxx>]

On 26.03.2021 19:59, Andrew Cooper wrote:
> If Legacy Replacement mode doesn't help in check_timer(), restore the old
> configuration before falling back to other workarounds.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> CC: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> CC: Frédéric Pierret <frederic.pierret@xxxxxxxxxxxx>
> 
> v2:
>  * New.
> 
> For 4.15: Attempt to unbreak AMD Ryzen 1800X systems.
> 
> I'm tempted to fold this into the previous patch, but its presented here in
> isolation for ease of review.

Both combined
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
(i.e. I think they strictly should be folded).

Just as a (further) consideration: While I continue to think that
undoing immediately is what we want, I wonder whether every further
fallback attempt wouldn't want to also be accompanied by trying if
it _combined_ with legacy replacement mode actually helps if alone
it didn't. Perhaps we want to cross that bridge only if we get a
respective report ...

Jan