Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

[Ian Jackson <iwj@xxxxxxxxxxxxxx>]

Andrew Cooper writes ("[PATCH v1.1 2/2] x86/hpet: Don't enable legacy 
replacement mode unconditionally"):
> From: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC
> static PIT clock gating") was reported to cause boot failures on certain
> AMD Ryzen systems.
> 
> Refine the fix to do nothing in the default case, and only attempt to
> configure legacy replacement mode if IRQ0 is found to not be working.
> 
> In addition, introduce a "hpet" command line option so this heuristic
> can be overridden.  Since it makes little sense to introduce just
> "hpet=legacy-replacement", also allow for a boolean argument as well as
> "broadcast" to replace the separate "hpetbroadcast" option.

I'm sorry, but I think it is too late for 4.15 to do this.  I prefer
Jan's patch which I have alread release-acked.

Can someone qualified please provide a maintainer review for this,
ideally today ?

Ian.