Re: [PATCH v1] piix: fix regression during unplug in Xen HVM domUs

[no-reply@xxxxxxxxxxx]

Patchew URL: https://patchew.org/QEMU/20210316224412.11609-1-olaf@xxxxxxxxx/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210316224412.11609-1-olaf@xxxxxxxxx
Subject: [PATCH v1] piix: fix regression during unplug in Xen HVM domUs

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      
patchew/20210311143958.562625-1-richard.henderson@xxxxxxxxxx -> 
patchew/20210311143958.562625-1-richard.henderson@xxxxxxxxxx
 * [new tag]         patchew/20210316224412.11609-1-olaf@xxxxxxxxx -> 
patchew/20210316224412.11609-1-olaf@xxxxxxxxx
Switched to a new branch 'test'
9b7ec0f piix: fix regression during unplug in Xen HVM domUs

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#41: FILE: hw/ide/piix.c:113:
+    if (pci_piix3_xen_ide_unplug_done == true)
[...]

total: 1 errors, 0 warnings, 29 lines checked

Commit 9b7ec0fe5d7c (piix: fix regression during unplug in Xen HVM domUs) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210316224412.11609-1-olaf@xxxxxxxxx/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxx