[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning
Julien Grall writes ("Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning"): > This is pretty much what we are already doing slowly by initializing > values to shut up older compilers. I agree this is more limited, but we > also waive off diagnostics from every single compiler in that code > rather than just one version. > > Hence why I suggested dropping -Werror for older compiler. This is not > ideal but it would give us the ability to keep support for dinausor > compiler and not hamper our ability to take advantage of newer compiler > diagnostics. I agree with Julien. I think we should avoid adding these redundant initialisers for the reasons he gives. > The ideal solution is to drop support for older compiler (see my other > thread). But this sounds like a daunting task so far on x86... > > Anyway, I will not Nack the patch but will also not Ack it. I will let > another maintainer ack this patch. But this is outside my usual area so I won't nack it either. Ian.
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |