Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API

[Jan Beulich <jbeulich@xxxxxxxx>]

On 11.03.2021 14:00, Andrew Cooper wrote:
> However, having laid things out in this way today, it occurs to me that
> we should consider further cleanup as well.
> 
> I do agree that code wanting to use the libxendevicemodel.h API almost
> certainly don't want/need the dmop ABI.  (i.e. an individual consumer
> will want one, or the other, but almost certainly not both together).
> 
> Should libxendevicemodel.h really be including dm_op.h?

I was indeed wondering.

>  AFAICT, it is
> only the ioserverid_t typedef which is API shared between the two
> contexts, and we can trivially typedef that locally.

Hmm, a local typedef isn't nice - there should be one central point.
Granted there's no risk for this to change in anywhere halfway
foreseeable future, but still. Also neither C89 nor C99 allow a
typedef to be repeated - in those versions we'd then rely on an
extension.

> This is something which we should either do now, or not at all.

Well, yes, would be better.

Jan