[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE
On 09.03.2021 08:28, Michal Orzel wrote: > > > On 08.03.2021 15:26, Jan Beulich wrote: >> On 08.03.2021 14:59, Michal Orzel wrote: >>> --- a/xen/arch/arm/Makefile >>> +++ b/xen/arch/arm/Makefile >>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>> >>> #obj-bin-y += ....o >>> >>> -ifdef CONFIG_DTB_FILE >>> +ifneq ($(CONFIG_DTB_FILE),"") >>> obj-y += dtb.o >>> AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>> endif >> >> Right now what I have for my Arm test builds is an unquoted >> string in ./.config, e.g.: >> >> CONFIG_DTB_FILE:=/usr/local/arm-linux-gnueabi/vexpress-v2p-aem-v7a.dtb >> >> While I suppose you've tested that the resulting quoting is still >> okay, to reduce confusion perhaps the AFLAGS-y line would better >> be changed to >> >> AFLAGS-y += '-DCONFIG_DTB_FILE=$(CONFIG_DTB_FILE)' > > It is tested. I can change it to: > AFLAGS-y += -DCONFIG_DTB_FILE='$(CONFIG_DTB_FILE)' > as the -DCONFIG_DTB_FILE= does not need to be within quotes Either way would seem better to me than the current use of escaped double quotes. (Personally I prefer to quote entire arguments, but that's clearly a taste aspect.) Jan
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |