|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API
Andrew Cooper writes ("[PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard
from public API"):
> Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library.
>
> That change actually broke the build with:
>
> include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t'
> ioservid_t *id);
> ^
>
> as libxendevicemodel.h now uses a type it can't see a typedef for. However,
> nothing noticed because the header.chk logic is also broken (fixed
> subsequently).
>
> Strip the guard from the public header, and remove compensation from
> devicemodel's private.h
Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |