Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters

[Ian Jackson <iwj@xxxxxxxxxxxxxx>]

Julien Grall writes ("[PATCH for-4.15] tools/xenstored: liveupdate: Increase 
the maximum number of parameters"):
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> The longest possible command line for LiveUpdate is:
> 
>   liveupdate -s -t <timeout> -F
> 
> This is 5 parameters. However, the maximum is currently specified to 4.
> This means the some of the parameters will get ignored.

Why are the extra parameters ignored rather than treated as errors ?
This seems like an invitation to making code with bad behaviour
(perhaps bad security-relevant behaviour).

CC Juergen who seems to have written the code...

> Update the field max_pars to 5 so and admin can specify the timeout and
> force at the same time.

Anyway, for this patch,

Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>