[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.15 4/5] tools/xenstore-control: Don't leak buf in live_update_start()

To: Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
From: Jürgen Groß <jgross@xxxxxxxx>
Date: Fri, 26 Feb 2021 08:06:07 +0100
Cc: raphning@xxxxxxxxxxxx, iwj@xxxxxxxxxxxxxx, Julien Grall <jgrall@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
Delivery-date: Fri, 26 Feb 2021 07:06:15 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.02.21 18:41, Julien Grall wrote:

From: Julien Grall <jgrall@xxxxxxxxxx>

All the error paths but one will free buf. Cover the remaining path so
buf can't be leaked.

This bug was discovered and resolved using Coverity Static Analysis
Security Testing (SAST) by Synopsys, Inc.

Fixes: 7f97193e6aa8 ("tools/xenstore: add live update command to 
xenstore-control")
Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>


Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

References:
- [PATCH for-4.15 0/5] xenstore: Address coverity issues in the LiveUpdate code
  - From: Julien Grall
- [PATCH for-4.15 4/5] tools/xenstore-control: Don't leak buf in live_update_start()
  - From: Julien Grall

Prev by Date: Re: [PATCH for-4.15 3/5] tools/xenstored: control: Store the save filename in lu_dump_state
Next by Date: RE: [PATCH v3 1/2][4.15] VMX: delay p2m insertion of APIC access page
Previous by thread: [PATCH for-4.15 4/5] tools/xenstore-control: Don't leak buf in live_update_start()
Next by thread: [PATCH for-4.15 5/5] tools/xenstored: Silence coverity when using xs_state_* structures
Index(es):
- Date
- Thread

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.