[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 4/8] x86/mm/tlb: Flush remote and local TLBs concurrently
- To: Nadav Amit <nadav.amit@xxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Thu, 18 Feb 2021 08:14:08 +0000
- Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Andy Lutomirski <luto@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Nadav Amit <namit@xxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>, Sasha Levin <sashal@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, x86@xxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, linux-hyperv@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Michael Kelley <mikelley@xxxxxxxxxxxxx>
- Delivery-date: Thu, 18 Feb 2021 08:15:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Given that the last patch killed the last previously existing
user of on_each_cpu_cond_mask there are now the only users.
> if (info->freed_tables) {
> - smp_call_function_many(cpumask, flush_tlb_func,
> - (void *)info, 1);
> + on_each_cpu_cond_mask(NULL, flush_tlb_func, (void *)info, true,
> + cpumask);
..
> + on_each_cpu_cond_mask(NULL, flush_tlb_func, (void *)info, true,
> + cpumask);
Which means the cond_func is unused, and thus on_each_cpu_cond_mask can
go away entirely in favor of on_each_cpu_cond.
|