|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 04/10] tools/libxl: Fix uninitialised variable in libxl__domain_get_device_model_uid()
Ian Jackson writes ("Re: [PATCH v2 04/10] tools/libxl: Fix uninitialised
variable in libxl__domain_get_device_model_uid()"):
> Uhhhhh. I think this and the other one seem to be stray hunks which
> each introduce a new uninitialised variable bug ?
I now think (following irc discussion) that I was wrong about this.
Use of intended_uid is conditional on user being set. This is very
confusing. This code is simulating a sum type. If only we had sum
types.
Reviewed-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
I think, given how confusing this is, that I would like another
careful review before I give my release-ack.
Ian.
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |