Re: [PATCH] xen-block: fix reporting of discard feature

[Kevin Wolf <kwolf@xxxxxxxxxx>]

Am 18.01.2021 um 16:49 hat Paul Durrant geschrieben:
> > -----Original Message-----
> > From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> > Sent: 18 January 2021 15:34
> > To: qemu-devel@xxxxxxxxxx
> > Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>; Arthur Borsboom 
> > <arthurborsboom@xxxxxxxxx>; Stefano
> > Stabellini <sstabellini@xxxxxxxxxx>; Anthony Perard 
> > <anthony.perard@xxxxxxxxxx>; Paul Durrant
> > <paul@xxxxxxx>; Kevin Wolf <kwolf@xxxxxxxxxx>; Max Reitz 
> > <mreitz@xxxxxxxxxx>; xen-
> > devel@xxxxxxxxxxxxxxxxxxxx; qemu-block@xxxxxxxxxx
> > Subject: [PATCH] xen-block: fix reporting of discard feature
> > 
> > Linux blkfront expects both "discard-granularity" and
> > "discard-alignment" present on xenbus in order to properly enable the
> > feature, not exposing "discard-alignment" left some Linux blkfront
> > versions with a broken discard setup. This has also been addressed in
> > Linux with:
> > 
> > https://lore.kernel.org/lkml/20210118151528.81668-1-roger.pau@xxxxxxxxxx/T/#u
> > 
> > Fix QEMU to report a "discard-alignment" of 0, in order for it to work
> > with older Linux frontends.
> > 
> > Reported-by: Arthur Borsboom <arthurborsboom@xxxxxxxxx>
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> Reviewed-by: Paul Durrant <paul@xxxxxxx>

Thanks, applied to the block branch.

Kevin