[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH XTF RFC] force-enable UMIP for UMIP testing

  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 29 Jan 2021 11:59:01 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fgPClt3mpdIr+JCViQaVR80m6+OcEmsf+zaegLFcEA0=; b=EULiud/sYIQmx+2h9CiqS0XAi8XzypQfjccwZHW919pErsN8C7xJRi5jTVvSDuTrz4cX0yR+1n81XmqQI13XTTBuLWXMWMuyBrLdG6pry9I91S7U96tKBlOe8XZIvvvaRPIZUf70nZglb+MPpfUN0Xktjo3swlunS+P/T0DvDVRAadc19gX+6DrJdGuZfxHvDiNhZ/NbeHLWmVbp8NJxSRK7AP+qInqhXZ8GCApGfH1EOLUYgZmGOSTgIwK3mMMO/h4PCMKmAjw8MhQtEkScnlgeAYDfQiMa33jlvs/1CkxgHygtLBj5QiuX+qFM15LtJInAtFLXBJcYrCtX7VbzFw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S4ZJvm347dlI5CcO7JJw8GyaZfHmrtSZ09SGEG6M7+5Pz6yGM34coSTL5TSftuXoLV52cfJR9+sWf/tqtCXSztLATvS4bh+IscX7jSCZ4i0+9wiL/UabhXVqaMwzw05QxSgKcFAsQjkkUQf/QeA2JFRC0qU+xydNP4MZdyebVBffCvE68PzpH141Wk3D8di3/MmbVCIjNja2lVjKz0IAz0F1KlfAYNQYx97JDg8PYH7Onwyosc4T3+kmPLKW8/F7vIM3CjW+49If/hBzD++QCnjMGv8Wq0r/6BXPo7UsFMSIUPUpghHnAkvNU25jLm+SLpLTH192vzqhnYoRQK8bNw==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Delivery-date: Fri, 29 Jan 2021 11:59:19 +0000
  • Ironport-sdr: E1q1prAAN7mq+6BSfegdP2vWlZDC1QCe9JAkNfAcMolgT/GI9hrExR5mQEtHPdpVMvW0ehEuCp zxBLntuOZpPKtPp+iVQhQGRsXnkjAVkJT0qqJFNd4LvWDBc9QKrFos6K7H56ol0n6EBCInqhxD 2fsS4WTb4nNmrsVJedZVNP5PlQZ11nSZPSRkgHRi831BMIqrY/EY4mNwaQeiKtOEwe+jxhghNP M75V5+39ehRsBCLpzGnJy6Z5CVxQfg9YO5FCa86SGfwaeY23HoevofVSPAE0OuoY4ZnL4dA4Fh dF0=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 29/01/2021 11:47, Jan Beulich wrote:
> Enable UMIP even if underlying hardware doesn't support it (assuming
> the respective change supporting its emulation is in place). Obviously,
> as explained in that patch, the SMSW test is then expected to fail on
> Intel hardware.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> --- a/tests/umip/Makefile
> +++ b/tests/umip/Makefile
> @@ -4,6 +4,8 @@ NAME      := umip
>  CATEGORY  := functional
>  TEST-ENVS := hvm32 hvm64
> +TEST-EXTRA-CFG := extra.cfg.in
> +
>  obj-perenv += main.o
>  include $(ROOT)/build/gen.mk
> --- /dev/null
> +++ b/tests/umip/extra.cfg.in
> @@ -0,0 +1 @@
> +cpuid = "host,umip=1"

So while I agree in principle that having UMIP emulation is a good
thing, this particular change in XTF would be rejected by the OSSTest

The only reason it doesn't fail straight away for the PV guests is
because there's no error handling from problematic CPUID requests, which
is something still to be fixed.

Given that SMSW is a known (and acceptable) hole in UMIP emulation under
Intel, it should be converted into a skip.  However, that is also a
logical change to the test, and will cause other problems for bisection.

This does need the test-revision logic (as does one other bug in the
UMIP test IIRC), which I need to get around to finishing.

I'll see about trying to do that early next release cycle, because the
"tests are logically immutable to avoid the bisector saying no"
restriction is getting in the way of a lot of people, myself included.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.