[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] xen/memory: Reject out-of-range resource 'frame' values
On 28.01.2021 17:06, Andrew Cooper wrote: > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -1054,7 +1054,7 @@ static long xatp_permission_check(struct domain *d, > unsigned int space) > } > > static int acquire_grant_table(struct domain *d, unsigned int id, > - unsigned long frame, > + unsigned int frame, > unsigned int nr_frames, > xen_pfn_t mfn_list[]) > { Doesn't this want carrying forward into gnttab_get_{shared,status}_frame() as well? Of course further cleanup here can also be done at a later point, but it leaves things in a somewhat inconsistent state. I'd like to leave it up to you to commit with Paul's R-b as is, or extend the adjustments and then also add mine. > --- a/xen/include/asm-x86/mm.h > +++ b/xen/include/asm-x86/mm.h > @@ -641,7 +641,7 @@ static inline bool arch_mfn_in_directmap(unsigned long > mfn) > } > > int arch_acquire_resource(struct domain *d, unsigned int type, > - unsigned int id, unsigned long frame, > + unsigned int id, unsigned int frame, > unsigned int nr_frames, xen_pfn_t mfn_list[]); Same here wrt hvm_get_ioreq_server_frame(). Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |