Re: [RFC PATCH 17/34] iomap: use bio_new in iomap_dio_zero

["Darrick J. Wong" <djwong@xxxxxxxxxx>]

On Wed, Jan 27, 2021 at 11:11:16PM -0800, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>

Looks ok to me,
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>

--D

> ---
>  fs/iomap/direct-io.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index ea1e8f696076..f6c557a1bd25 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -189,15 +189,13 @@ iomap_dio_zero(struct iomap_dio *dio, struct iomap 
> *iomap, loff_t pos,
>       int flags = REQ_SYNC | REQ_IDLE;
>       struct bio *bio;
>  
> -     bio = bio_alloc(GFP_KERNEL, 1);
> -     bio_set_dev(bio, iomap->bdev);
> -     bio->bi_iter.bi_sector = iomap_sector(iomap, pos);
> +     bio = bio_new(iomap->bdev, iomap_sector(iomap, pos), REQ_OP_WRITE,
> +                   flags, 1, GFP_KERNEL);
>       bio->bi_private = dio;
>       bio->bi_end_io = iomap_dio_bio_end_io;
>  
>       get_page(page);
>       __bio_add_page(bio, page, len, 0);
> -     bio_set_op_attrs(bio, REQ_OP_WRITE, flags);
>       iomap_dio_submit_bio(dio, iomap, bio, pos);
>  }
>  
> -- 
> 2.22.1
>